Skip to content

Scc 5050 2#622

Open
danamansana wants to merge 104 commits intomainfrom
scc-5050-2
Open

Scc 5050 2#622
danamansana wants to merge 104 commits intomainfrom
scc-5050-2

Conversation

@danamansana
Copy link
Copy Markdown
Contributor

@danamansana danamansana commented Jan 20, 2026 •
edited
Loading

  • lib/resources was a mix of several different concerns. This PR separates functions for building ES queries into a new helper files, in order to pare down lib/resources and achieve a closer match between functions and routes
  • Changes the strategy for building ES query bodies. Instead of extensive mutation, the new approach removes mutation of ES query bodies. This should make it easier to match the fields in the return value to what is actually being passed to ES.
  • Helper methods for building ES queries have been moved to separate files.
  • Constructing filters for Es queries moved to Es query builder where they should have been
  • lib/resources has been rewritten to use async/await instead of promise chaining

charmingduchess and others added 30 commits June 2, 2025 10:39
@charmingduchess
Merge pull request #491 from NYPL/main
b1b4547 
Actual firedrill time!
@nonword
Override agg-self-filtering behavior for open search
7685722 
Trying out overriding the policy of _not_ applying namesake filter to
aggregations when there is no other search criteria

https://newyorkpubliclibrary.atlassian.net/browse/SCC-4789
@nonword
Merge branch 'NOREF-filter-self-filtering-fix' into qa2
472331e
@danamansana
Fix query structure
579eec5
@danamansana
Add more permissive key structure
ae28b72
@danamansana
Remove console logs and commented code
8b6000f
@danamansana
Fix linter errors
e5b61dc
@danamansana
Move esRangeValue
b85f3fb
@danamansana
Move parseParams
a02a058
@danamansana
Refactor nyplSourc/id calculation and move nyplSourceAndId to utils'
0beec4c
@danamansana
Add bodybuilder methods for findByUri
a749878
@danamansana
Add nyplSourceAndId call to annotatedMarc
683445f
@danamansana
Move itemsByFilter to utils
5ac57ee
@danamansana
Move buildElasticQuery/Body to bodybuilder
d50ea45
@danamansana
Factor out body for search
2f6c887
@danamansana
Move buildElasticAggregationsBody
1075d65
@danamansana
Move aggregationQueriesForParams to bodybuilder
a0237b7
@danamansana
Move mergeAggregationsResposes to utils
3340f5e
@danamansana
Factor out body for aggregation
e072d93
@danamansana
Move findByUri to async/await
054d1e4
@danamansana
Make annotatedMarc async
2d60b15
@danamansana
Make deliveryLocationsByBarcode async
2ec818a
@danamansana
Merge pull request #597 from NYPL/NOREF/bnf-test
c784247 
Noref/bnf test
@danamansana
Pull search from promise chain in search
ba7fcf5
@danamansana
Pull massaged response from promise chain in resources#search
9189c1b
@danamansana
Pull ResourceResultsSerializer.serialize from promise chain in search
3297b63
@danamansana
Remove nested promise
03d57dc
@danamansana
Remove promise from search
1c34469
@danamansana
Factor out relevance report
6e8af8d
@danamansana
Make aggregation endpoint async
cf7edcd
@yossariano
Copy link
Copy Markdown
Contributor

yossariano commented Mar 17, 2026

Merged the latest main in and updated to play nice with contributor browse changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nonword nonword nonword left review comments

@charmingduchess charmingduchess charmingduchess requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danamansana @yossariano @nonword @charmingduchess